Refactoring: Refactorings/Replace Temp with Query

From Notes
Jump to navigation Jump to search

Temporary value variable used to store result of an expression; chances are that expression is used elsewhere. Temps create longer methods.

See also: Split Temporary Variable, Separate Query from Modifier

Mechanics

  1. Extract right-hand side of assignment into a method
    Note: Mark method as private at first; easier to relax protection than swim through tons of public methods
    Ensure extrated method is free of side effects (i.e. doesn't modify any object). Use Separate Query from Modifier
  2. Test
  3. Inline Temp on the temporary variable

Example

Before

def price 

 base_price = @quantity * @item_price

 if base_price > 1000
   discount_factor * 0.95
 else
   discount_factor * 0.98
 end
 base_price * discount_factor

end

After

def price 

 base_price * discount_factor

end

def discount_factor 

 base_price > 1000 ? 0.95 : 0.98

end

def base_price 

 @quantity * @item_price

end

Refactorings
Composing Methods

Extract Method • Inline Method • Inline Temp • Replace Temp with Query • Replace Temp with Chain • Introduce Explaining Variable • Split Temporary Variable • Remove Assignments to Parameters • Replace Method with Method Object • Substitute Algorithm • Replace Loop with Collection Closure Method • Extract Surrounding Method • Introduce Class Annotation • Introduce Named Parameter • Remove Named Parameter • Remove Unused Default Parameter • Dynamic Method Definition • Replace Dynamic Receptor with Dynamic Method Definition • Isolate Dynamic Receptor • Move Eval from Runtime to Parse Time

Moving Features Between Objects

Move Method • Move Field • Extract Class • Inline Class • Hide Delegate • Remove Middle Man

Organizing Data

Self Encapsulate Field • Replace Data Value with Object • Change Value to Reference • Change Reference to Value • Replace Array with Object • Replace Hash with Object • Change Unidirectional Association to Bidirectional • Change Bidirectional Association to Unidirectional • Replace Magic Number with Symbolic Content • Encapsulate Collection • Replace Record with Data Class • Replace Type Code with Polymorphism • Replace Type Code with Module Extension • Replace Type Code with State-Strategy • Replace Subclass with Fields • Lazily Initialized Atribute • Eagerly Initialized Attribute

Simplifying Conditional Expressions

Decompose Conditional • Recompose Conditional • Consolidate Conditional Expression • Consolidate Duplicate Conditional Fragments • Remove Control Flag • Replace Nested Conditional with Guard Clauses • Replace Conditional with Polymorphism • Introduce Null Object • Introduce Assertion

Making Method Calls Simpler

Rename Method • Add Parameter • Remove Parameter • Separate Query from Modifier • Parameterize Method • Replace Parameter with Explicit Methods • Preserve Whole Object • Replace Parameter with Method • Introduce Parameter Object • Remove Setting Method • Hide Method • Replace Constructor with Factory Method • Replace Error Code with Exception • Replace Exception with Test • Introduce Gateway • Introduce Expression Builder

Dealing with Generalization

Pull Up Method • Push Down Method • Extract Module • Inline Module • Extract Subclass • Introduce Inheritance • Collapse Hierarchy • Form Template Method • Replace Inheritance with Delegation • Replace Delegation with Hierarchy • Replace Abstract Superclass with Module

Big Refactorings

Tease Apart Inheritance • Convert Procedural Design to Objects • Separate Domain from Presentation • Extract Hierarchy

Retrieved from "https://notes.komputerwiz.net/w/index.php?title=Refactoring:_Refactorings/Replace_Temp_with_Query&oldid=820"